Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table Text Got Truncated in Small Screen Issue #9906

Closed
wants to merge 2 commits into from
Closed

Fix Table Text Got Truncated in Small Screen Issue #9906

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd4d73
Fix table text got truncated in small screen issue
Goodyear2017 Apr 4, 2024
3419b31
Move css from site.css to less file
Goodyear2017 Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/NuGetGallery/Content/Site.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1726,3 +1726,15 @@ img.contributors-contributor-avatar {
font-size: 1.1em;
padding: 5px 15px 5px 15px;
}
.container.page-statistics-overview td {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have both a less and css file. Should we update the .less file instead of the css file in this case?
On other day I saw @martinrrm is making changes in less file generating the css changes from it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erdembayar Just made the change, move the css from site.css to less file. Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to generate .css change from .less file and check-in both into our code repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinrrm could you please confirm if above is correct process?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goodyear2017 For changes in styles, we change the .less file and then update the css with grunt. We have some docs on how to update those files here https://github.com/NuGet/NuGetGallery/blob/main/docs/Frontend.md, let me know if you have questions. Thanks

text-overflow: inherit;
overflow: auto;
}

.container.page-statistics-most-downloaded .table tbody td {
overflow: auto;
text-overflow:inherit;
}