Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly no-op deprecations and allow unlisting at the same time in API #9922

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

joelverhagen
Copy link
Member

There is continued internal success and growing interesting in the deprecation API. I would like to make progress on the public preview.

Spec: https://github.com/NuGet/Engineering/pull/4709

For no-oping deprecations, I opted to not use the entity level change tracking API (e.g. https://stackoverflow.com/a/30235307) since it would mean a lot of changes to our abstractions. I think the current implementation is easier to understand anyway.

Summary of changes:

This will improve V3 performance for cases when a deprecation has not changed on a version
Plumb through proper audit reason for deprecation via API
@joelverhagen joelverhagen requested a review from a team as a code owner April 17, 2024 20:12
@joelverhagen joelverhagen merged commit 8033d34 into dev Apr 25, 2024
3 checks passed
@joelverhagen joelverhagen deleted the jver-depr branch April 25, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants