Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relist and deprecate to unlist scope #9938

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Add relist and deprecate to unlist scope #9938

merged 3 commits into from
Apr 29, 2024

Conversation

joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Apr 29, 2024

The existing unlist API key scope already has the relist and deprecate capabilities. This updates the supporting text used on the API keys page to mention these capabilities.

Progress on #8873.

Summary of changes:

  • Add relist to the API key label since it's always been there
  • Make wording of package vs. package versions consistent (unlist/relist/deprecate is done at the version level)
  • Show deprecate capability on the API key if the user is in the flight
  • Delete some unused string in src/NuGetGallery/Strings.resx
  • Fix web.config indentation for binding redirects

Before

image

After

image

The relist API already uses the unlist scope. It has since we introduced API scopes. The deprecate action will be mentioned in the scope description only if the user is part of the deprecation API flight.
@joelverhagen joelverhagen requested a review from a team as a code owner April 29, 2024 14:11
advay26
advay26 previously approved these changes Apr 29, 2024
@joelverhagen joelverhagen merged commit 659e9b1 into dev Apr 29, 2024
2 checks passed
@joelverhagen joelverhagen deleted the jver-fixscope branch April 29, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants