Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes for Dark theme #9949

Merged
merged 1 commit into from
May 28, 2024
Merged

UI fixes for Dark theme #9949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 108 additions & 86 deletions src/Bootstrap/dist/css/bootstrap-theme.css
View file
Open in desktop

Large diffs are not rendered by default.

84 changes: 60 additions & 24 deletions src/Bootstrap/dist/css/bootstrap.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/Bootstrap/less/alerts.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
.alert-brand-a {
a {
color: var(--brandForegroundLinkRest);

text-decoration: underline;

&:hover,
&:focus {
color: var(--brandForegroundLinkHover);
Expand Down
2 changes: 1 addition & 1 deletion src/Bootstrap/less/buttons.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
outline: none !important; // removes focus from .tab-focus()
}
}
.brand-button-transparent {
.btn-brand-transparent {
color: var(--neutralForeground2Rest);
background-color: var(--transparentBackgroundRest);
border-radius: var(--Medium, 4px);
Expand Down
16 changes: 8 additions & 8 deletions src/Bootstrap/less/code.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ samp {
code {
padding: 2px 4px;
font-size: 90%;
color: @code-color;
background-color: @code-bg;
color: var(--statusDangerForeground1Rest);
background-color: var(--statusDangerBackground1Rest);
border-radius: @border-radius-base;
}

// User input typically entered via keyboard
kbd {
padding: 2px 4px;
font-size: 90%;
color: @kbd-color;
background-color: @kbd-bg;
color: var(--neutralForeground1Rest);
background-color: var(--neutralBackground1Rest);
border-radius: @border-radius-small;
box-shadow: inset 0 -1px 0 rgba(0, 0, 0, .25);

Expand All @@ -44,12 +44,12 @@ pre {
margin: 0 0 (@line-height-computed / 2);
font-size: (@font-size-base - 1); // 14px to 13px
line-height: @line-height-base;
color: @pre-color;
color: var(--neutralForeground2Rest);
word-break: break-all;
word-wrap: break-word;
background-color: @pre-bg;
border: 1px solid @pre-border-color;
border-radius: @border-radius-base;
background-color: var(--neutralBackground1Rest);
border: 2px solid var(--neutralStroke1Rest);
border-radius: 4px;

// Account for some code outputs that place code tags in pre tags
code {
Expand Down
24 changes: 21 additions & 3 deletions src/Bootstrap/less/forms.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,33 +229,51 @@ input[type="checkbox"].brand-checkbox:focus {
justify-content: space-evenly;
}

input[type="checkbox"]:indeterminate::after {
content: '\2012';
font-weight: bolder;
display: flex;
width: 16px;
height: 16px;
left: -1px;
top: -1.75px;
position: relative;
align-items: flex-end;
justify-content: space-evenly;
}

input[type="checkbox"]:indeterminate,
input[type="checkbox"]:checked {
background-color: var(--brandBackgroundCompoundRest);
border-color: var(--brandBackgroundCompoundRest);
color: var(--neutralForegroundInverted1Rest);;
}

&:hover {
input[type="checkbox"]:indeterminate,
input[type="checkbox"]:checked {
background-color: var(--brandBackgroundCompoundHover);
border-color: var(--brandBackgroundCompoundHover);
color: var(--neutralForegroundInverted1Hover);
}

input[type="checkbox"]:not(:checked){

input[type="checkbox"]:not(:indeterminate):not(:checked),
input[type="checkbox"]:not(:checked):not(:indeterminate) {
border-color: var(--neutralStrokeAccessibleHover);
color: var(--neutralForegroundInverted1Hover);
}
}

&:active {
input[type="checkbox"]:indeterminate
input[type="checkbox"]:checked {
background-color: var(--brandBackgroundCompoundPressed);
border-color: var(--brandBackgroundCompoundPressed);
color: var(--neutralForegroundInverted1Pressed);
}

input[type="checkbox"]:not(:checked){
input[type="checkbox"]:not(:indeterminate):not(:checked),
input[type="checkbox"]:not(:checked):not(:indeterminate) {
border-color: var(--neutralStrokeAccessiblePressed);
color: var(--neutralForegroundInverted1Pressed);
}
Expand Down
14 changes: 9 additions & 5 deletions src/Bootstrap/less/pager.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,22 @@
display: inline-block;
padding: 5px 14px;
font-size: 20px;
color: @gray-light;
color: var(--neutralForeground2Rest);

> a,
> span {
color: @link-color;
color: var(--neutralForeground2Rest);

&:hover {
color: var(--neutralForeground2Hover);
}
}
}

.next {
border-left-style: solid;
border-left-width: 1px;
border-left-color: @brand-primary;
border-left-color: var(--neutralStrokeAccessibleRest);
}

.previous {
Expand All @@ -39,9 +43,9 @@
> a:hover,
> a:focus,
> span {
color: @pager-disabled-color;
color: var(--neutralForegroundDisabledRest);
cursor: @cursor-disabled;
background-color: @pager-bg;
background-color: transparent;
}
}
}
3 changes: 3 additions & 0 deletions src/Bootstrap/less/scaffolding.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ textarea {


// Links
a.inline {
text-decoration: underline;
}

a {
color: var(--brandForegroundLinkRest);
Expand Down
1 change: 1 addition & 0 deletions src/Bootstrap/less/theme/all.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
@import "page-admin-popularity-transfers.less";
@import "page-api-keys.less";
@import "page-blog.less";
@import "page-contact.less";
@import "page-delete-account.less";
@import "page-display-package.less";
@import "page-downloads.less";
Expand Down
Loading