Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to 8.0.301 sdk #9986

Merged
merged 2 commits into from
Jun 28, 2024
Merged

move to 8.0.301 sdk #9986

merged 2 commits into from
Jun 28, 2024

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jun 4, 2024

v-manil2 and others added 2 commits May 28, 2024 23:25
[ReleasePrep][2024.05.28]RI of dev into main
@SimonCropp SimonCropp requested a review from a team as a code owner June 4, 2024 12:13
@joelverhagen
Copy link
Member

This seems reasonable, we just need to make sure our various CI and release pipelines are happy with this change. Thanks!

@joelverhagen joelverhagen changed the base branch from main to dev June 4, 2024 14:13
@joelverhagen
Copy link
Member

Our release builds have some problem with this change. I think we would need to explicitly install .NET 8 to a special place, or something like that. It will take us some time to work out these changes (some of which may be closed source). Is this change blocking you?

@SimonCropp
Copy link
Contributor Author

SimonCropp commented Jun 5, 2024

I think we would need to explicitly install .NET 8 to a special place

if u move to using the dotnet-install scripts it will respect your globa.json and install the correct version

Is this change blocking you?

.net 6 is 3 years old and i did not have it installed. imo it make sense to target the current stable, since there are security fixes and new features that are unlocked by using it

@SimonCropp
Copy link
Contributor Author

can we merge this?

@SimonCropp
Copy link
Contributor Author

@joelverhagen can we merge this?

@erdembayar
Copy link
Contributor

can we merge this?

Sorry, it's quite busy period. Just pushed changes to internal release pipeline. Let's see if it fixes the problem.

@erdembayar
Copy link
Contributor

erdembayar commented Jun 28, 2024

can we merge this?

Sorry, it's quite busy period. Just pushed changes to internal release pipeline. Let's see if it fixes the problem.

I created PR for internal release pipeline, hopefully I get approval by tomorrow. We need to merge them same time, otherwise things would break.

Copy link
Contributor

@erdembayar erdembayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution.

@erdembayar erdembayar merged commit 5a9e29e into NuGet:dev Jun 28, 2024
2 checks passed
@SimonCropp SimonCropp deleted the move-to-8.0.301-sdk branch June 28, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants