Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore rider temp files #9987

Merged
merged 2 commits into from
Jun 4, 2024
Merged

ignore rider temp files #9987

merged 2 commits into from
Jun 4, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

v-manil2 and others added 2 commits May 28, 2024 23:25
@v-manil2
Merge pull request #9961 from NuGet/dev
84c4347 
[ReleasePrep][2024.05.28]RI of dev into main
@SimonCropp
ignore rider temp files
2ee86f7
@SimonCropp SimonCropp requested a review from a team as a code owner June 4, 2024 12:14
@joelverhagen joelverhagen changed the base branch from main to dev June 4, 2024 12:44
@joelverhagen
Copy link
Member

Changed based branch to dev since we do all non-hotfixes against dev. Thanks for the contribution. Looks good to me!

@joelverhagen joelverhagen merged commit 4d63db3 into NuGet:dev Jun 4, 2024
2 checks passed
@SimonCropp
Copy link
Contributor Author

can u change the default branch to dev, so that PRs target it by default

@SimonCropp SimonCropp deleted the ignore-rider-temp-files branch June 5, 2024 00:15
@joelverhagen joelverhagen mentioned this pull request Jun 5, 2024
Open
@joelverhagen
Copy link
Member

We choose main to be the default branch to allow git clone distributions of our source (and Download ZIP upon landing on the repo, etc) to use a version of the Gallery that is deployed to PROD. This is essentially the "last known good". Certainly, there are other ways to do this but this was our team practice for years. I wouldn't want to make this decision unilaterally so I'll open it as an issue that the team can discuss: #10013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelverhagen joelverhagen joelverhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @joelverhagen @v-manil2