This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
GetRawBody method
#423
Merged
GetRawBody method
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbanni
reviewed
Feb 24, 2024
| @@ -20,5 +21,6 @@ public interface IReceivedBrokeredMessage | |||
| Task AbandonAsync(); | |||
| string GetBody(); | |||
| TStream GetBody<TStream>(); | |||
| Stream GetRawBody(); | |||
There was a problem hiding this comment.
This is a breaking change on a public interface, do we need to be concerned about that here?
There was a problem hiding this comment.
We're the only consumer and the only meaningful implementation is shipped with the interface. It might break tests (in case we have test implementation of that interface), but I'll fix those as I update the package in consuming projects. So, I don't think there is a concern.
mariaghiondea
approved these changes
Feb 24, 2024
sbanni
approved these changes
Feb 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the monitoring jobs requires access to raw message body data to properly deserialize the message. Calling
BrokeredMessage.GetBody<Stream>worked with the previous version of the Service Bus library. Migrating to new version broke that (as there is no direct equivalent and our reimplementation disregarded that case). Adding explicit method to support that scenario.Another potential solution here is to update
GetBody<TStream>implementation to check ifTStreamisSystem.IO.Streamand do something else, but I'm not sure what else it might break. Creating new method is safer.