This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
[Package Signing] Store a package signature's end certificate instead of the full chain #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster and
dtivel
|
@loic-sharma, |
xavierdecoster
approved these changes
Oct 13, 2017
scottbommarito
approved these changes
Oct 13, 2017
dtivel
approved these changes
Oct 13, 2017
| /// The time at which this signature was created. A signature is valid as long as it was signed | ||
| /// before its certificates were revoked and/or expired. This timestamp SHOULD come from a trusted | ||
| /// before its certificates were revoked and/or expired. This timestamp MUST come from a trusted | ||
| /// timestamp authority. | ||
| /// </summary> | ||
| public DateTime SignedAt { get; set; } |
There was a problem hiding this comment.
Consider using DateTimeOffset instead wherever you use DateTime.
There was a problem hiding this comment.
Talked to Damon offline. Using DateTimeOffset properties changes the SQL Server column type from datetime2 to datetimeoffset. This datetimeoffset type stores both the UTC timestamp and the client's offset from the UTC timestamp. Considering that all other entities use DateTime, we decided it would be better to stick to DateTime and then enforce that all code uses UTC timestamp.
shishirx34
approved these changes
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single certificate may have multiple valid certificate chains (see the "Certificate chains and cross-certification" section here). Therefore, we should not store the full certificate chain when validating a certificate as this may change. Instead, the certificate's chain should be rebuilt every time the certificate is validated.
I also added the
InvalidCertificateStatus. UnlikeRevoked, anInvalidstatus invalidates ALL signatures that depends on this certificate.These are breaking changes, however, we haven't run the "AddPackageSigninigSchema" migration anywhere.