Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Deterministic pack docs" #1684

Merged
merged 1 commit into from
Sep 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/reference/cli-reference/cli-ref-pack.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ where `<nuspecPath>` and `<projectPath>` specify the `.nuspec` or project file,
| --- | --- |
| BasePath | Sets the base path of the files defined in the [.nuspec](../nuspec.md) file. |
| Build | Specifies that the project should be built before building the package. |
| Deterministic | Specify if the command should create a deterministic package. Multiple invocations of the pack command will generate the exact same byte-to-byte package. The output of the pack command is not affected by the ambient state of the machine. Specifically zip entries will be timestamped as 1980-01-01. To achieve full determinism, the assemblies should be built with the respective compiler option [-deterministic](/dotnet/csharp/language-reference/compiler-options/deterministic-compiler-option). |
| Exclude | Specifies one or more wildcard patterns to exclude when creating a package. To specify more than one pattern, repeat the -Exclude flag. See example below. |
| ExcludeEmptyDirectories | Prevents inclusion of empty directories when building the package. |
| ForceEnglishOutput | *(3.5+)* Forces nuget.exe to run using an invariant, English-based culture. |
Expand Down
13 changes: 0 additions & 13 deletions docs/reference/msbuild-targets.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ Note that the `Owners` and `Summary` properties from `.nuspec` are not supported
- NuspecFile
- NuspecBasePath
- NuspecProperties
- Deterministic

## pack scenarios

Expand Down Expand Up @@ -170,18 +169,6 @@ You can also add the following metadata to your project reference:
<PrivateAssets>
```

### Deterministic

When using `MSBuild -t:pack -p:Deterministic=true`, multiple invocations of the the pack target will generate the exact same package.
The output of the pack command is not affected by the ambient state of the machine. Specifically zip entries will be timestamped as 1980-01-01. To achieve full determinism, the assemblies should be built with the respective compiler option [-deterministic](/dotnet/csharp/language-reference/compiler-options/deterministic-compiler-option).
It is recommended that you specify the deterministic property like following, so both the compiler and NuGet will respect it.

```xml
<PropertyGroup>
<Deterministic>true</Deterministic>
</PropertyGroup>
```

### Including content in a package

To include content, add extra metadata to the existing `<Content>` item. By default everything of type "Content" gets included in the package unless you override with entries like the following:
Expand Down