Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security audit concept doc #3060

Merged
merged 8 commits into from
Jun 6, 2023
Merged

Add security audit concept doc #3060

merged 8 commits into from
Jun 6, 2023

Conversation

JonDouglas
Copy link
Contributor

Initial drop of security auditing concept doc. Will require screenshots and we can elaborate more on other methods as well such as dotnet list package --vulnerable and NuGet.org features if desired.

@JonDouglas JonDouglas requested a review from zivkan May 4, 2023 19:56
@learn-build-service-prod
Copy link

Learn Build status updates of commit 7f29a0c:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ⚠️Warning View Details

docs/concepts/Auditing-Packages.md

  • Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
  • Line 65, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Restore' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@zivkan zivkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this docs page!


## About security audits

A security audit for package managers like NuGet is a process that involves analyzing the security of the packages that are included in a software project. This involves identifying vulnerabilities, evaluating risks, and making recommendations for improving security. The audit can include a review of the packages themselves, as well as any dependencies and their associated risks. The goal of the audit is to identify and mitigate any security vulnerabilities that could be exploited by attackers, such as code injection or cross-site scripting attacks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML ignores whitespace, and markdown converts any empty line into a new div or paragraph. So, I suggest starting every new sentence on a new line (without a line of whitespace, obviously), so that after the PR is merged, if someone edits a sentence in the paragraph, only 1 line in the diff will show changes, rather than the entire paragraph. This is particularly useful when git/github gets a bit confused and doesn't highlight what exactly changed in the line, which is more likely on very long lines.

Same for other multi-sentence paragraphs in this doc, please 😃

docs/concepts/Auditing-Packages.md Outdated Show resolved Hide resolved
docs/concepts/Auditing-Packages.md Show resolved Hide resolved

If security vulnerabilities are found and updates are available for the package, you can either:

- Edit the `.csproj`, `packages.config`, or other package version location with a newer version containing a security fix.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you can't edit a packages.config file, because that will leave all the references in the project file pointing to an invalid directory (the old package version directory). For packages.config projects, customers must upgrade the package in Visual Studio.

docs/concepts/Auditing-Packages.md Outdated Show resolved Hide resolved
Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit ae4b9e5:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ⚠️Warning View Details

docs/concepts/Auditing-Packages.md

  • Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
  • Line 73, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Restore' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 136eda6:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ⚠️Warning View Details

docs/concepts/Auditing-Packages.md

  • Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
  • Line 73, Column 2: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'Restore' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit ab2b3f8:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ⚠️Warning View Details

docs/concepts/Auditing-Packages.md

  • Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 499b2d5:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@JonDouglas JonDouglas marked this pull request as ready for review June 5, 2023 19:30
@JonDouglas JonDouglas requested review from a team as code owners June 5, 2023 19:30
@JonDouglas
Copy link
Contributor Author

Should be good to review and ship

@JonDouglas JonDouglas requested a review from zivkan June 5, 2023 19:31
Copy link
Member

@zivkan zivkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel kind of strongly that we should remove references of packages.config (unless we want to mention that it's not currently supporting NuGetAudit), until it's implemented and we know which preview of VS it will be first available.

docs/concepts/Auditing-Packages.md Outdated Show resolved Hide resolved
docs/concepts/Auditing-Packages.md Show resolved Hide resolved
docs/concepts/Auditing-Packages.md Show resolved Hide resolved
JonDouglas and others added 2 commits June 6, 2023 09:33
Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit cda04e1:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 9269104:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3abb595:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/Auditing-Packages.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@JonDouglas JonDouglas merged commit f9f9e09 into main Jun 6, 2023
@JonDouglas JonDouglas deleted the auditing-packages branch June 6, 2023 15:03
nkolev92 pushed a commit that referenced this pull request Jun 14, 2023
* Updated Finding-and-Choosing-Packages.md (#3042)

* Add security audit concept doc (#3060)

* Add security audit concept doc

* Update docs/concepts/Auditing-Packages.md

Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>

* Fix editing section

* Update Auditing-Packages.md

* Add h1

* Update Auditing-Packages.md

* Update docs/concepts/Auditing-Packages.md

Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>

* Update Auditing-Packages.md

---------

Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>

* Update NuGet-FAQ.yml (#3066)

Add Q# as supported language

* Add the Native Target Framework (#3067)

In the Blog Post (https://devblogs.microsoft.com/nuget/native-support/#native-target-framework) it is precisely stated that you should specify the "native" target framework, when developing win32 applications

* Document MSBuildSdk package type (#3036)

* Update readme page doc (#3025)

* update allowlist + additional markdown feature support

* reword

---------

Co-authored-by: Lynn Dai <lind@microsoft.com>

* NuGet June 2023 servicing release udpates (#3072)

---------

Co-authored-by: Rishi Joshi <110519406+tangorishi@users.noreply.github.com>
Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>
Co-authored-by: Bradben <bradben@comcast.net>
Co-authored-by: bub1ick <51718131+bub1ick@users.noreply.github.com>
Co-authored-by: Rob Mensching <rob@firegiant.com>
Co-authored-by: lyndaidaii <64443925+lyndaidaii@users.noreply.github.com>
Co-authored-by: Lynn Dai <lind@microsoft.com>
Co-authored-by: Heng Liu <45407901+heng-liu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants