Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NuGetAuditSuppress info in NU1901-4 docs #3332

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Aug 10, 2024

fixes: https://github.com/NuGet/Client.Engineering/issues/2899

I checked the auditing packages page already has the good information, so it doesn't need an update, just the NU1901-4 warning code page.

@zivkan zivkan requested review from a team as code owners August 10, 2024 00:27
Copy link

Learn Build status updates of commit 03905c0:

✅ Validation status: passed

File Status Preview URL Details
docs/reference/errors-and-warnings/NU1901-NU1904.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@@ -47,14 +47,7 @@ For example, `<NuGetAuditLevel>high</NuGetAuditLevel>`.

If you would like to suppress a specific advisory, add an MSBuild [NuGetAuditSuppress](../../concepts/Auditing-Packages.md#excluding-advisories) item.
For example `<NuGetAuditSuppress Include="https://github.com/advisories/GHSA-g3q9-xf95-8hp5" />`.
`NuGetAuditSuppress` is available from VS 17.11 and .NET 8.0.400 SDK for projects using `PackageReference`, and from VS 17.12 for projects using `packages.config`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link the release notes maybe?

@aortiz-msft aortiz-msft self-requested a review August 13, 2024 22:57
@zivkan zivkan merged commit 9a8e293 into main Aug 17, 2024
2 checks passed
@zivkan zivkan deleted the zivkan-suppress-update branch August 17, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants