Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Node.js 16 #42

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Update to use Node.js 16 #42

merged 1 commit into from
Oct 12, 2022

Conversation

TheRealMattV
Copy link
Contributor

No description provided.

@TheRealMattV TheRealMattV requested a review from a team as a code owner October 11, 2022 20:55
@TheRealMattV TheRealMattV changed the title Update the to use Node.js 16 Update to use Node.js 16 Oct 11, 2022
@jeffkl
Copy link
Contributor

jeffkl commented Oct 11, 2022

@TheRealMattV do you know if there are any implications with using one version of Node or the other? I don't see any information in the docs. Like if we target a newer version, will some people not be able to use this action?

@jeffkl jeffkl self-assigned this Oct 11, 2022
@TheRealMattV
Copy link
Contributor Author

@TheRealMattV do you know if there are any implications with using one version of Node or the other? I don't see any information in the docs. Like if we target a newer version, will some people not be able to use this action?

@jeffkl I'm not aware of any issues. Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12

@martincostello
Copy link

Yep, users using this action are starting to get warnings that Node.js 12 will be deprecated.

See also Azure/webapps-deploy#253 for the same ask elsewhere driven by the same annoucement.

Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@jeffkl jeffkl merged commit cc62c9a into NuGet:main Oct 12, 2022
@TheRealMattV TheRealMattV deleted the chore/use-node-16 branch October 12, 2022 16:48
@jeffkl jeffkl mentioned this pull request Oct 12, 2022
vbreuss referenced this pull request in Testably/Testably.Abstractions Feb 12, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [NuGet/setup-nuget](https://togithub.com/NuGet/setup-nuget) | action |
minor | `v1.0.5` -> `v1.1.1` |

---

### Release Notes

<details>
<summary>NuGet/setup-nuget</summary>

###
[`v1.1.1`](https://togithub.com/NuGet/setup-nuget/releases/tag/v1.1.1)

[Compare
Source](https://togithub.com/NuGet/setup-nuget/compare/v1.1.0...v1.1.1)

#### What's Changed

- Update [@&#8203;actions/core](https://togithub.com/actions/core) from
1.9.1 to 1.10.0 by [@&#8203;jeffkl](https://togithub.com/jeffkl) in
[https://github.com/NuGet/setup-nuget/pull/44](https://togithub.com/NuGet/setup-nuget/pull/44)
- Update dist by [@&#8203;jeffkl](https://togithub.com/jeffkl) in
[https://github.com/NuGet/setup-nuget/pull/45](https://togithub.com/NuGet/setup-nuget/pull/45)

**Full Changelog**:
NuGet/setup-nuget@v1.1.0...v1.1.1

###
[`v1.1.0`](https://togithub.com/NuGet/setup-nuget/releases/tag/v1.1.0)

[Compare
Source](https://togithub.com/NuGet/setup-nuget/compare/v1.0.7...v1.1.0)

#### What's Changed

- Update to use Node.js 16 by
[@&#8203;TheRealMattV](https://togithub.com/TheRealMattV) in
[https://github.com/NuGet/setup-nuget/pull/42](https://togithub.com/NuGet/setup-nuget/pull/42)
- Update dist by [@&#8203;jeffkl](https://togithub.com/jeffkl) in
[https://github.com/NuGet/setup-nuget/pull/43](https://togithub.com/NuGet/setup-nuget/pull/43)

#### New Contributors

- [@&#8203;TheRealMattV](https://togithub.com/TheRealMattV) made their
first contribution in
[https://github.com/NuGet/setup-nuget/pull/42](https://togithub.com/NuGet/setup-nuget/pull/42)

**Full Changelog**:
NuGet/setup-nuget@v1.0.7...v1.1.0

###
[`v1.0.7`](https://togithub.com/NuGet/setup-nuget/releases/tag/v1.0.7)

[Compare
Source](https://togithub.com/NuGet/setup-nuget/compare/v1.0.6...v1.0.7)

#### What's Changed

- build(deps): bump
[@&#8203;actions/core](https://togithub.com/actions/core) from 1.6.0 to
1.9.1 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/NuGet/setup-nuget/pull/41](https://togithub.com/NuGet/setup-nuget/pull/41)

**Full Changelog**:
NuGet/setup-nuget@v1.0.6...v1.0.7

###
[`v1.0.6`](https://togithub.com/NuGet/setup-nuget/releases/tag/v1.0.6)

[Compare
Source](https://togithub.com/NuGet/setup-nuget/compare/v1.0.5...v1.0.6)

#### What's Changed

- Update packages by [@&#8203;jeffkl](https://togithub.com/jeffkl) in
[https://github.com/NuGet/setup-nuget/pull/35](https://togithub.com/NuGet/setup-nuget/pull/35)

#### New Contributors

- [@&#8203;jeffkl](https://togithub.com/jeffkl) made their first
contribution in
[https://github.com/NuGet/setup-nuget/pull/35](https://togithub.com/NuGet/setup-nuget/pull/35)

**Full Changelog**:
NuGet/setup-nuget@v1.0.3...v1.0.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzAuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEzMC4xIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants