This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Added support for PackageDownload items #895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
force-pushed
the
feature/package-download
branch
from
cb7ef21 to
d1514b7
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
We are looking into this PR |
|
NuGet implementation details: NuGet/Home#7339 |
2 tasks
|
Closing in favor of #986 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature!
Currently
PackageDownloadis not a supported target as supported element that can contain a version. (This is seriously a thing)🆕 What is the new behavior (if this is a feature change)?
Adds support for
PackageDownload. The behavior is very similar toPackageReferenceexcept that the version must be defined as an exact version[1.0.0]instead of just1.0.0.💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Testing with and without
PackageDownload.📝 Links to relevant issues/docs
This is seriously a thing, today Nuke is using it ensure that packages are downloaded, but they are not implicitly referenced. This is used in the Nuke context to ensure that the binaries exist. I could not however find any specific documentation on this behavior, but it is a thing.
https://github.com/NuGet/NuGet.Client/blob/f5916a527c442f896f787c593252b37a345da835/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L845-L850
🤔 Checklist before submitting