Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated node-pty to support new node versions #489

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Conversation

cognitivegears
Copy link
Collaborator

Updated node-pty to fix error when running with node v20.5.1 (maybe others)

Copy link
Owner

@NuSkooler NuSkooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out - all seems to be working well! Thank you for your work on this!

package.json Show resolved Hide resolved
@NuSkooler
Copy link
Owner

OK I did have to fix one thing: onExit() emits a object of {exitCode, signal}.

@NuSkooler NuSkooler merged commit bbfef53 into master Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants