Fix quick_tune parameter error when calling set_frequency on BladeRF1 #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use quicktune parameters when calling schedule_retune with attached XB-200
Xb 200 fix schedule retune error
rghilduta
reviewed
Feb 28, 2023
| } | ||
|
|
||
| status = dev->board->schedule_retune(dev, ch, BLADERF_RETUNE_NOW, 0, &qt); | ||
| } |
There was a problem hiding this comment.
Any chance this right curly bracket } can be on the same line as the else statement?
There was a problem hiding this comment.
I'm trying to make sense of this. If the XB200 is attached, how does bladerf_get_quick_tune() return a bladerf_quick_tune that is for the correct new frequency?
There was a problem hiding this comment.
I meant to fix this issue: #882
But i do not have equipment here to retest at the moment. Maybe i do not understand the error correctly.
|
Thanks for the submission! Looks good, finally got around to testing! Question, can you please correct this quick stylist issue? c8f72ab#r1119705939 |
Style fix
|
Feel free to edit my merge request at any time. I am not picky in that regard ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error when XB-200 board is attached:
[ERROR @ host/libraries/libbladeRF/src/board/bladerf1/bladerf1.c:2398] Consider supplying the quick_tune parameter to bladerf_schedule_retune() when the XB-200 is enabled.