Remove player entity context from player offers #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller refactors than hoped, but better to get part of the work out of the way anyway rather than be stuck forever. 😅
With the goal to split games across multiple server instances, we want to be able to request that a player joins without having the player physically on the server yet. Most games probably do not care about working with a
ServerPlayerEntity
, so just passing theGameProfile
should be enough even for the most exotic cases (e.g. player rejoining a game).