Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove player entity context from player offers #298

Merged
merged 13 commits into from
Nov 5, 2024
Merged

Conversation

Gegy
Copy link
Member

@Gegy Gegy commented Jul 15, 2024

Smaller refactors than hoped, but better to get part of the work out of the way anyway rather than be stuck forever. 😅
With the goal to split games across multiple server instances, we want to be able to request that a player joins without having the player physically on the server yet. Most games probably do not care about working with a ServerPlayerEntity, so just passing the GameProfile should be enough even for the most exotic cases (e.g. player rejoining a game).

@Gegy Gegy self-assigned this Jul 15, 2024
@Patbox Patbox merged commit 27ad8ce into 1.21 Nov 5, 2024
1 of 2 checks passed
@haykam821 haykam821 added this to the 0.6.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants