Add Zren/mpv-osc-tethys #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based my entry on mpv_thumbnail_script as I bundle a patched version of it's server.lua for the thumbnails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based my entry on
mpv_thumbnail_scriptas I bundle a patched version of it'sserver.luafor the thumbnails.PR requested by @z8512 at Zren/mpv-osc-tethys#8.
Note: While using
mpv_thumbnail_scriptas an example, I noticed that it's trying to install the generated lua files in the "release page". The source code repo that is cloned does not have those files, so I'm guessing thatmpv_thumbnail_scriptdoesn't install properly with your package manager.That's besides the point though, as the last generated lua release by TheAMM is missing a crucial bugfix (which is part of the reason I bundle my own
server.lua).