feat(modifier-managers): use 3.22 capabilities

BREAKING CHANGE: destruction behavior changed to use new args proxy from 3.22 Resolves the issue described by: emberjs/ember.js#19162 fixed by: emberjs/ember.js#19163
NullVoxPopuli · Oct 16, 2020 · 21e0abd · 21e0abd
1 parent a8d4da7
commit 21e0abd
Show file tree

Hide file tree

Showing 6 changed files with 2,670 additions and 2,599 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -47,11 +47,6 @@ jobs:
 
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.4
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.8
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.12
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.16
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.20
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary

diff --git a/addon/-private/class/modifier-manager.ts b/addon/-private/class/modifier-manager.ts
@@ -11,7 +11,7 @@ function destroyModifier(modifier: ClassBasedModifier): void {
 }
 
 export default class ClassBasedModifierManager {
-  capabilities = capabilities('3.13');
+  capabilities = capabilities('3.22');
 
   constructor(private owner: unknown) {}
 

diff --git a/addon/-private/functional/modifier-manager.ts b/addon/-private/functional/modifier-manager.ts
@@ -29,7 +29,7 @@ function setup(
 }
 
 class FunctionalModifierManager {
-  capabilities = capabilities('3.13');
+  capabilities = capabilities('3.22');
 
   createModifier(factory: Factory): FunctionalModifier {
     // This looks superfluous, but this is creating a new instance

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -12,46 +12,6 @@ module.exports = async function () {
   return {
     useYarn: true,
     scenarios: [
-      {
-        name: 'ember-lts-3.4',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.4.0',
-          },
-        },
-      },
-      {
-        name: 'ember-lts-3.8',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.8.0',
-          },
-        },
-      },
-      {
-        name: 'ember-lts-3.12',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.12.0',
-          },
-        },
-      },
-      {
-        name: 'ember-lts-3.16',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.16.0',
-          },
-        },
-      },
-      {
-        name: 'ember-lts-3.20',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.20.0',
-          },
-        },
-      },
       {
         name: 'ember-release',
         npm: {

diff --git a/package.json b/package.json
@@ -40,9 +40,7 @@
     "ember-cli-babel": "^7.22.1",
     "ember-cli-normalize-entity-name": "^1.0.0",
     "ember-cli-string-utils": "^1.1.0",
-    "ember-cli-typescript": "^3.1.3",
-    "ember-destroyable-polyfill": "^2.0.2",
-    "ember-modifier-manager-polyfill": "^1.2.0"
+    "ember-cli-typescript": "^3.1.3"
   },
   "devDependencies": {
     "@ember/optional-features": "^1.3.0",
@@ -66,14 +64,13 @@
     "ember-cli-sri": "^2.1.1",
     "ember-cli-typescript-blueprints": "^3.0.0",
     "ember-cli-uglify": "^3.0.0",
-    "ember-decorators-polyfill": "^1.0.6",
     "ember-disable-prototype-extensions": "^1.1.3",
     "ember-export-application-global": "^2.0.1",
     "ember-load-initializers": "^2.1.1",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-qunit": "^4.6.0",
     "ember-resolver": "^8.0.0",
-    "ember-source": "~3.20.2",
+    "ember-source": "~3.22.0",
     "ember-source-channel-url": "^2.0.1",
     "ember-template-lint": "^2.9.1",
     "ember-try": "^1.4.0",