Skip to content

Commit

Permalink
feat(modifier-managers): use 3.22 capabilities
Browse files Browse the repository at this point in the history
BREAKING CHANGE: destruction behavior changed to use new args proxy from
3.22

Resolves the issue
  described by: emberjs/ember.js#19162
  fixed by: emberjs/ember.js#19163
  • Loading branch information
NullVoxPopuli committed Oct 20, 2020
1 parent 9aee8de commit d65b6b6
Show file tree
Hide file tree
Showing 2 changed files with 746 additions and 6 deletions.
10 changes: 8 additions & 2 deletions type-tests/modifier-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,19 @@ import { expectTypeOf } from 'expect-type';
import Modifier, { modifier, ModifierArgs } from 'ember-modifier';

// --- function modifier --- //
expectTypeOf(modifier).toEqualTypeOf<
expectTypeOf(modifier).toMatchTypeOf<
(
callback: (
element: Element,
positional: unknown[],
named: Record<string, unknown>
) => (() => unknown) | void
) =>
| ((
element: Element,
positional: unknown[],
named: Record<string, unknown>
) => unknown)
| void
) => unknown
>();

Expand Down
Loading

0 comments on commit d65b6b6

Please sign in to comment.