Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Invert default: use 2-stage transform, as the single stage transform is *hard* #15

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

NullVoxPopuli
Copy link
Owner

From the embroider meeting on Tuesday, 2023-03-28

  • double babel parse is costly + complicated
    • does need to be avoided for apps, but this rollup plugin is presently only for v2 addons
    • could be mitigated if the template-parser and preprocess plugin were written in rust (using SWC)
      • would be good to port transpilation to SWC anyway, vast speed improvements
  • having the preprocess separate allows for only one babel parse (which is during normal babel transform) -- allowing this plugin to maybe work for apps later on

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: bf84978

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rollup-plugin-glimmer-template-tag Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@NullVoxPopuli NullVoxPopuli merged commit e36d1d6 into main Mar 29, 2023
@NullVoxPopuli NullVoxPopuli deleted the invert-defaults branch March 29, 2023 19:35
@github-actions github-actions bot mentioned this pull request Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant