You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While running cargo-goggles on the top 5000 most recently downloaded crates I've discovered that release v0.4.6 of async-compression doesn't include 22ed0ac, possibly because of running cargo publish from the release branch while #247 was getting merged.
The output of the diff command is the following (skipping differences in Cargo.toml and Cargo.lock):
diff -r our-release/async-compression-0.4.6/src/codec/gzip/decoder.rs upstream/async-compression-0.4.6/src/codec/gzip/decoder.rs83,92c83,84<< let res = inner(self, input, output);<< if (output.written().len() > prior) {< // update CRC even if there was an error< self.crc.update(&output.written()[prior..]);< }<< let done = res?;<---> let done = inner(self, input, output)?;> self.crc.update(&output.written()[prior..]);diff -r our-release/async-compression-0.4.6/src/futures/bufread/generic/decoder.rs upstream/async-compression-0.4.6/src/futures/bufread/generic/decoder.rs68,69d67< let mut first = true;<73,81c71,74< let input = if first {< &[][..]< } else {< ready!(this.reader.as_mut().poll_fill_buf(cx))?< };<< if input.is_empty() && !first {< // Avoid attempting to reinitialise the decoder if the< // reader has returned EOF.---> let input = ready!(this.reader.as_mut().poll_fill_buf(cx))?;> if input.is_empty() {> // Avoid attempting to reinitialise the decoder if the reader> // has returned EOF.83d75<87,98c79< let done = this.decoder.decode(&mut input, output).or_else(|err| {< // ignore the first error, occurs when input is empty< // but we need to run decode to flush< if first {< Ok(false)< } else {< Err(err)< }< })?;<< first = false;<---> let done = this.decoder.decode(&mut input, output)?;
Can we get a new release out?
The text was updated successfully, but these errors were encountered:
While running cargo-goggles on the top 5000 most recently downloaded crates I've discovered that release v0.4.6 of async-compression doesn't include 22ed0ac, possibly because of running
cargo publish
from the release branch while #247 was getting merged.This can be verified from the following script:
The output of the
diff
command is the following (skipping differences inCargo.toml
andCargo.lock
):Can we get a new release out?
The text was updated successfully, but these errors were encountered: