Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making a new release #263

Closed
paolobarbolini opened this issue Apr 1, 2024 · 1 comment
Closed

Consider making a new release #263

paolobarbolini opened this issue Apr 1, 2024 · 1 comment

Comments

@paolobarbolini
Copy link
Contributor

While running cargo-goggles on the top 5000 most recently downloaded crates I've discovered that release v0.4.6 of async-compression doesn't include 22ed0ac, possibly because of running cargo publish from the release branch while #247 was getting merged.

This can be verified from the following script:

git clone https://github.com/Nullus157/async-compression.git
cd async-compression/
git checkout async-compression-v0.4.6
cargo publish --no-verify --dry-run --package async-compression
cd ..
cp async-compression/target/package/async-compression-0.4.6.crate our-release.tar.gz

curl -o upstream.tar.gz --fail "https://static.crates.io/crates/async-compression/async-compression-0.4.6.crate"

mkdir our-release
mkdir upstream
tar -xvzf our-release.tar.gz -C our-release
tar -xvzf upstream.tar.gz -C upstream
diff -r our-release upstream

The output of the diff command is the following (skipping differences in Cargo.toml and Cargo.lock):

diff -r our-release/async-compression-0.4.6/src/codec/gzip/decoder.rs upstream/async-compression-0.4.6/src/codec/gzip/decoder.rs
83,92c83,84
< 
<                     let res = inner(self, input, output);
< 
<                     if (output.written().len() > prior) {
<                         // update CRC even if there was an error
<                         self.crc.update(&output.written()[prior..]);
<                     }
< 
<                     let done = res?;
< 
---
>                     let done = inner(self, input, output)?;
>                     self.crc.update(&output.written()[prior..]);
diff -r our-release/async-compression-0.4.6/src/futures/bufread/generic/decoder.rs upstream/async-compression-0.4.6/src/futures/bufread/generic/decoder.rs
68,69d67
<         let mut first = true;
< 
73,81c71,74
<                     let input = if first {
<                         &[][..]
<                     } else {
<                         ready!(this.reader.as_mut().poll_fill_buf(cx))?
<                     };
< 
<                     if input.is_empty() && !first {
<                         // Avoid attempting to reinitialise the decoder if the
<                         // reader has returned EOF.
---
>                     let input = ready!(this.reader.as_mut().poll_fill_buf(cx))?;
>                     if input.is_empty() {
>                         // Avoid attempting to reinitialise the decoder if the reader
>                         // has returned EOF.
83d75
< 
87,98c79
<                         let done = this.decoder.decode(&mut input, output).or_else(|err| {
<                             // ignore the first error, occurs when input is empty
<                             // but we need to run decode to flush
<                             if first {
<                                 Ok(false)
<                             } else {
<                                 Err(err)
<                             }
<                         })?;
< 
<                         first = false;
< 
---
>                         let done = this.decoder.decode(&mut input, output)?;

Can we get a new release out?

@robjtede
Copy link
Member

robjtede commented Apr 1, 2024

published v0.4.7 and amended the releases

@robjtede robjtede closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants