Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush data still available in the decoder when no input (#123) #247

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Sep 19, 2023

rebased #129

closes #123

@michalfita
Copy link

Pinging @NobodyXu may speed up things.
Thank you for doing this @robjtede.

src/codec/gzip/decoder.rs Outdated Show resolved Hide resolved
@NobodyXu
Copy link
Collaborator

Sorry, I reviewed this afternoon but forgot to publish it.

src/codec/gzip/decoder.rs Outdated Show resolved Hide resolved
@NobodyXu
Copy link
Collaborator

cc @robjtede

@robjtede
Copy link
Member Author

sorry for the (mega) delay, hope this can get into the release

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@NobodyXu NobodyXu added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 6e3996d Jan 17, 2024
16 checks passed
@NobodyXu NobodyXu deleted the fix-123 branch January 17, 2024 05:27
@NobodyXu NobodyXu mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoder might block if there is data remaining to be flushed from the codec and the stream blocks
4 participants