Skip to content

Commit

Permalink
char: ipmi: enable NPCM KCS after IRQ config
Browse files Browse the repository at this point in the history
NPCM KCS IRQ probe order caused a crash because
the IRQ was enabled before the IRQ handler was linked.

this commit Modify probe IRQ order in the NPCM KCS
driver to first link a handler to the interrupt
and then enable the KCS channel and the IRQ.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
  • Loading branch information
tmaimon committed Apr 17, 2022
1 parent ae6df3e commit 3e42438
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/char/ipmi/kcs_bmc_npcm7xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,10 @@ static int npcm7xx_kcs_probe(struct platform_device *pdev)

dev_set_drvdata(dev, kcs_bmc);

npcm7xx_kcs_enable_channel(kcs_bmc, true);
rc = npcm7xx_kcs_config_irq(kcs_bmc, pdev);
if (rc)
return rc;
npcm7xx_kcs_enable_channel(kcs_bmc, true);

rc = misc_register(&kcs_bmc->miscdev);
if (rc) {
Expand Down

0 comments on commit 3e42438

Please sign in to comment.