Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MasonInstallAll: only the first linter for each filetype is installed #308

Closed
LeonardoMor opened this issue Jul 8, 2024 · 0 comments · Fixed by #309
Closed

MasonInstallAll: only the first linter for each filetype is installed #308

LeonardoMor opened this issue Jul 8, 2024 · 0 comments · Fixed by #309

Comments

@LeonardoMor
Copy link
Contributor

A common workflow is to have say pylint and cspell, for example, for python files. But the way the linters installation is coded, only the first linter specified for each file type would be installed.

LeonardoMor added a commit to LeonardoMor/ui that referenced this issue Jul 8, 2024
LeonardoMor added a commit to LeonardoMor/ui that referenced this issue Jul 9, 2024
siduck pushed a commit that referenced this issue Jul 9, 2024
* fix(nvim-lint): add/correct some linters

Squashed commit of the following:

commit 5d6c844978b0b7a8acfc607cbfdab3dfb63d8392
Author: Leonardo Mora <leonardo_mora@dell.com>
Date:   Mon Jul 8 12:09:01 2024 -0600

    feat(nvim-lint): add snyk and htmlhint

    See: rshkarin/mason-nvim-lint#8

commit 984d655b220a3b235b81fcbcc6c3eb0c3d9a0e0c
Author: Leonardo Mora <leonardo_mora@dell.com>
Date:   Mon Jul 8 11:57:02 2024 -0600

    fix(nvim-lint): correct ansible-lint mapping

    See: rshkarin/mason-nvim-lint#9

commit 806b42fa650f97a8bac445bd727552261dee81ec
Author: Leonardo Mora <leonardo_mora@dell.com>
Date:   Mon Jul 8 11:55:03 2024 -0600

    feat(nvim-lint): add checkmake

    Linter for Makefiles. See: rshkarin/mason-nvim-lint#10

commit a376b63f49fd02f3502b006108fc373b1efb5611
Author: Leonardo Mora <leonardo_mora@dell.com>
Date:   Sun Jul 7 19:41:15 2024 -0600

    refactor(formatters): better name

* fix(MasonInstallAll): fix linters installation. Fixes #308

* refactor(get_pkgs): expose this function

I find this extremely useful. So added this to have access to this
table.

* refactor(get_pkgs): consider data when handling duplicates

The way it was, you could end up with duplicates introduced by the
incoming data list.

* refactor: no need to re-assign the source table when using
vim.list_extend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant