Use simple require for feature list #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, if you can just fix the tests, it would be awesome 👌 |
|
Seems fixed. I used a tricky trick, but should be good enough. That said this will probably break on windows env. This 6to5 thing for publishing is annoying. Maybe we should handle this package with io.js which is doing this automatically (es6 to 5 on files directly), don't you think ? |
|
Hmmm, this is a good idea, not now, but it could be nice. |
Nyalab
added a commit
that referenced
this pull request
Feb 4, 2015
Use simple require for feature list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #18.
This also include a little commit to handle #19 until we get a real solution.