-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Callback examples is (still) not valid #1375
Comments
We should definitely make a distinction between examples that are complete and those that are just fragments. I'm not sure we want to completely outlaw fragment examples, but they should be identifiable. |
Thanks @darrelmiller I agree, and I'd suggest two relevant guidelines:
I've just submitted PR #1376 to complete the callback example. |
#1376 was merged. Thanks all. |
In his comment on #1228, @whitlockjc writes:
This was a suggestion to remove the
openapi
andinfo
properties from the model, which suggestion was followed.I'd argue that this is approach achieves a false economy. The brevity gain is all of four lines. And it rules out a valuable potential use-case for the example (one I'm using, but I have to blacklist this example), namely: using the examples in the repo's master branch as live data for tests in OAI tooling projects.
If folks concur, I'm glad to do a PR restoring the omitted lines.
The text was updated successfully, but these errors were encountered: