Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Microsoft VS Code OAS 3.0 extension #1952

Merged
merged 2 commits into from
Aug 3, 2019
Merged

Add Microsoft VS Code OAS 3.0 extension #1952

merged 2 commits into from
Aug 3, 2019

Conversation

DSotnikov
Copy link
Contributor

No description provided.

@MikeRalphson
Copy link
Member

Thanks. The language column is intended to help users find projects written in particular languages (especially to find projects to collaborate on), so "Any" isn't really helpful, though I gather this project may be semi- closed-source (source available). Is TypeScript more appropriate?

I'm also hesitant to add projects which do not support OAS 3.0's requirement that both JSON and YAML forms be supported. I'm aware that this is on your roadmap.

@DSotnikov
Copy link
Contributor Author

Thanks, Mike! I've changed the language field as requested.

YAML support comes within days now - so feel free to wait a little. I will add a comment to this thread once the extension gets updated with the feature.

@DSotnikov
Copy link
Contributor Author

Hi, Mike, YAML support is in the extension now.

@DSotnikov
Copy link
Contributor Author

@MikeRalphson, anything else you need from me at this point to merge the pull request?

I have fixed the Language field, and we have added YAML support to the tool.

@DSotnikov
Copy link
Contributor Author

@MikeRalphson Is there anything preventing you from merging the PR now?

I can issue a new PR if that makes things easier. Just let me know.

MikeRalphson
MikeRalphson approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@MikeRalphson MikeRalphson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks. Will let another member of @OAI/tsc merge.

@darrelmiller darrelmiller merged commit 26c0287 into OAI:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeRalphson MikeRalphson MikeRalphson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DSotnikov @MikeRalphson @darrelmiller