Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal to clarify nullable #2050

Merged
merged 15 commits into from
Nov 12, 2019
Merged

Add proposal to clarify nullable #2050

merged 15 commits into from
Nov 12, 2019

Commits on Apr 17, 2018

  1. Merge pull request #2 from OAI/master 

    Updating master from upstream repo
    @tedepstein
    tedepstein authored Apr 17, 2018
    Configuration menu
    Copy the full SHA
    2fe1ec8 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2019

  1. Merge remote-tracking branch 'upstream/master' 

    Catching up with changes in the upstream repo.
    @tedepstein
    tedepstein committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    d20a217 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Merge remote-tracking branch 'upstream/master'

    @tedepstein
    tedepstein committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    dacf5c7 View commit details
    Browse the repository at this point in the history

  2. Addressing OAI#1389, and clearing the way for PRs OAI#2046 and OAI#1977… 

    …. This adds a formal proposal to clarify the semantics of nullable, providing the necessary background and links to related resources.
    @tedepstein
    tedepstein committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    905dacd View commit details
    Browse the repository at this point in the history

  3. Corrected table formatting.

    @tedepstein
    tedepstein committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    cddbc1e View commit details
    Browse the repository at this point in the history

  4. Minor tweaks and corrections.

    @tedepstein
    tedepstein committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    a64f81a View commit details
    Browse the repository at this point in the history

  5. Correct Change Log heading.

    @tedepstein
    tedepstein committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    3f25047 View commit details
    Browse the repository at this point in the history

  6. Cleaned up notes about translation to JSON Schema and *Of inheritance… 

    … semantics.
    @tedepstein
    tedepstein committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    d58009a View commit details
    Browse the repository at this point in the history

  7. Fix Change Log heading in the proposal template.

    @tedepstein
    tedepstein committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    d1e3d94 View commit details
    Browse the repository at this point in the history

  8. Snappy answers to stupid questions.

    @tedepstein
    tedepstein committed Oct 31, 2019
    1 Configuration menu
    Copy the full SHA
    c58f5bf View commit details
    Browse the repository at this point in the history

  9. Change single-quote 'null' to double-quote "null" 

    Thanks, @handrews for the review.
    @tedepstein
    tedepstein authored Oct 31, 2019
    Configuration menu
    Copy the full SHA
    92fa3a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Clarified the proposed definition of nullable 

    Somehow in our collaborative editing, we neglected to state that `nullable` adds `"null"` to the set of allowed types. We just said that it "expands" the `type` value, but didn't state the obvious (to us) manner of said expansion. Correcting that oversight in this commit.
    @tedepstein
    tedepstein authored Nov 1, 2019
    Configuration menu
    Copy the full SHA
    e1c5bc9 View commit details
    Browse the repository at this point in the history

  2. Corrected the alternative, heavy-handed interpretation of nullable.

    @tedepstein
    tedepstein committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    63a71b5 View commit details
    Browse the repository at this point in the history

  3. Added more explicit detail about the primary use case.

    @tedepstein
    tedepstein committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    7d94b7c View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Added a more complete explanation of the problems created by disallow… 

    …ing nulls by default.
    @tedepstein
    tedepstein committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    e456a98 View commit details
    Browse the repository at this point in the history