Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs about summary and description #2393

Conversation

InfoSec812
Copy link
Contributor

Addresses #2392 by creating 2 new definitions at the beginning of the specification and linking to those definitions wherever summary and description are used in the standard.

@MikeRalphson I think that this can safely "balance" between verbosity and clarity. Looking forward to your thoughts.

@InfoSec812 InfoSec812 changed the base branch from master to v3.1.0-dev November 2, 2020 16:58
@LikeLakers2
Copy link

You ought to include those headers in the Table of Contents, for consistency with how everything else is in the TOC. :)

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't reintroduce the 120-character suggested limit, this was deliberately dropped in v3.0.0. I'm not convinced by the value of top level definitions as a solution to your issue, as it requires readers to have two regions of the spec. in mind at the same time.

versions/3.1.0.md Outdated Show resolved Hide resolved
versions/3.1.0.md Outdated Show resolved Hide resolved
InfoSec812 and others added 2 commits November 2, 2020 12:21
Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com>
Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com>
@InfoSec812
Copy link
Contributor Author

InfoSec812 commented Nov 2, 2020

I'm not convinced by the value of top level definitions as a solution to your issue, as it requires readers to have two regions of the spec. in mind at the same time.

I'm interested in better understanding your concerns @MikeRalphson ... In my mind, the links are there for if someone wants clarification, but they can be ignored when users of the Spec are already familiar with the differences between summary/description.

…om:InfoSec812/OpenAPI-Specification into improve_docs_about_summary_and_description
@hkosova
Copy link
Contributor

hkosova commented Nov 2, 2020

It MUST be plaintext and not contain formatting like Markdown or HTML.

This sentence is probaby unnecessary because the "Rich Text Formatting" section states that only description fields support Markdown.

Plus, "must not contain formatting" may be interpreted as if validators/linters need to explicitly check for the presence of Markdown / HTML tags in summaries and in that case flag the definition as invalid, which looks like an overkill.

@MikeRalphson
Copy link
Member

I'm interested in better understanding your concerns @MikeRalphson ... In my mind, the links are there for if someone wants clarification, but they can be ignored when users of the Spec are already familiar with the differences between summary/description.

I think the fact that they can be ignored points towards the fact that in their current state, they're merely redundant, not adding anything above and beyond the summary and description field descriptions in the field tables. But, and this is a biggie, I'm just one voice, and the point of the PR is to let others weigh in.

@InfoSec812
Copy link
Contributor Author

@MikeRalphson With regards to the definitions and reciprocal links, I feel like it is useful for those who are NOT as deeply familiar with the OAS standards so that they can quickly become familiar without having to seek out an expert to get an explanation. My own case being a potential example. Even though I am a frequent and regular user of OAS, I was not aware and did not quickly see the reasoning of why summary/description were different and how they were different. I would like to think that we could create a standards document which is more inclusive and fosters people at all levels of experience to be able to understand and contribute to the discussion.

@InfoSec812
Copy link
Contributor Author

InfoSec812 commented Nov 2, 2020

This sentence is probably unnecessary because the "Rich Text Formatting" section states that only description fields support Markdown.

Resolved, and agreed that it is well explained further down...

Plus, "must not contain formatting" may be interpreted as if validators/linters need to explicitly check for the presence of Markdown / HTML tags in summaries and in that case flag the definition as invalid, which looks like an overkill.

Removed.

@webron webron closed this Jul 8, 2021
@webron webron deleted the branch OAI:v3.1.0-dev July 8, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants