Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Proposal 003 "Clarify Nullable" to Promoted status #2529

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

tedepstein
Copy link
Contributor

The proposal was adopted in OpenAPI version 3.0.3. This pull request updates the proposal with that status change.

The proposal was adopted in OpenAPI version 3.0.3. This pull request updates the proposal with that status change.
proposals/003_Clarify-Nullable.md Outdated Show resolved Hide resolved
Changed status to 'Promoted' in accordance with the proposal template.
@MikeRalphson
Copy link
Member

As a result of #2604 the prefix/filename for this proposal has changed. The filename is now 2019-10-31-Clarify-Nullable.md. Please could you update this PR to match? Apologies for the extra work.

@tedepstein
Copy link
Contributor Author

tedepstein commented Jun 18, 2021

Hi @MikeRalphson, I merged in the main branch and it looks like that updated the filename. Please take a look and see if this is ready to merge.

@tedepstein tedepstein changed the title Update Proposals 003 "Clarify Nullable" to approved status Update Proposals 003 "Clarify Nullable" to Promoted status Jun 18, 2021
@tedepstein tedepstein changed the title Update Proposals 003 "Clarify Nullable" to Promoted status Update Proposal 003 "Clarify Nullable" to Promoted status Jun 18, 2021
@karenetheridge
Copy link
Member

A true value adds "null" to the allowed type specified by the type keyword, only if type is explicitly defined within the same Schema Object. Other Schema Object constraints retain their defined behavior, and therefore may disallow the use of null as a value. A false value leaves the specified or default type unmodified. The default value is false.

Is this proposal still valid? As of OpenAPI 3.1.0, JSON Schema is fully integrated, and the use of a 'nullable' keyword to modify the behaviour of another keyword ('type') would violate the JSON Schema specification (OpenAPI can add new keywords in its vocabulary, but keywords already defined in other vocabularies cannot be modified.)

@tedepstein
Copy link
Contributor Author

@karenetheridge , this proposal was adopted in version 3.0.3, changing the language used to describe nullable. It clarifies the meaning of nullable in OpenAPI 3.0 and earlier. There is no nullable keyword in OpenAPI 3.1, as JSON Schema already allows for type arrays like type: ["string", "null"].

@karenetheridge
Copy link
Member

thanks for the clarification. I didn't realize that this was already done for 3.0.3, as opposed to being a new proposal for 3.1.x.

@webron webron dismissed MikeRalphson’s stale review November 18, 2021 17:42

Requested change implemented.

@webron webron merged commit f3ffc79 into OAI:main Nov 18, 2021
Copy link

@Roberto-sour Roberto-sour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como puedo quitar la aplicación de macropay app novo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants