-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow booleans in place of any top-level schema field #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
jdesrosiers
approved these changes
Jun 4, 2021
There can be also added some example with {
"type": "object",
"required": [
"anySchema"
],
"properties": {
"anySchema": true,
"cannotBeDefined": false
}
} type: object
required:
- anySchema
properties:
anySchema: true
cannotBeDefined: false |
@magicmatatjahu rather than add examples to the spec, I have updated the |
252fdae
to
e4ddc4b
Compare
Good to know, let's wait for people's opinion. Feel free to use these examples anywhere you want. |
darrelmiller
approved these changes
Jun 10, 2021
charjr
pushed a commit
to charjr/OpenAPI-Specification
that referenced
this pull request
Apr 27, 2023
* fix: erroneous reference to v3.0 of the spec as if it was the current version Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com> * Allow boolean values for top level schemaObjects Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
charjr
pushed a commit
to charjr/OpenAPI-Specification
that referenced
this pull request
Apr 27, 2023
* fix: erroneous reference to v3.0 of the spec as if it was the current version Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com> * Allow boolean values for top level schemaObjects Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement PR for #2598
This targets
v3.1.1
as we have agreed this is a clarification. The change spells out thatboolean
values MAY be used wherever aschemaObject
is allowed.A separate PR (#2614) updates the
tests
folder with passing and failing cases for this issue.Plus one bonus fix.