-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor simplification of v3.1 schema #2671
minor simplification of v3.1 schema #2671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, this doesn't work like I intended.
Would you mind also making a couple other corrections I noticed when reviewing?
- The "allowEmptyValue" property doesn't apply to headers. That can be removed.
- The schema doesn't include the constraint that one and only of "schema" or "content" is required.
yes, give me a day or two |
Are you sure? https://spec.openapis.org/oas/v3.1.0#headerObject specifies that it's the same as parameter, except no 'name' or 'in' -- and 'parameter' has 'allowEmptyValue'. edit: ok, on reading the spec more closely, it doesn't really make sense how this would be applied to headers. removing.
done. |
Sorry, I meant the "allowReserved" property doesn't apply to headers. 🤦 I came to this conclusion because the Actually, now that I look at it again, it looks like the same is true of |
039ee8a
to
80c6e23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
"if the X property is present, then apply this constraint to property X" can be simplified by simply stating the constraint for property X.
80c6e23
to
25ca57f
Compare
"if the X property is present, then apply this constraint to property X" can
be simplified by simply stating the constraint for property X.