Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #2796 some IETF links were correct in the markdown syntax, but the generated HTML had broken links.
For example, the markdown for the Request Body Object > Fixed Fields (4.8.13.1) looks like this:
But the rendered HTML looks like this:
The problem occurs due to the markdown pre-processor code used to adjust RFC links.
It looks like the original intent of lines 267-269 was to transform links that looked like this:
Into this format:
I'm not sure what the reasoning was for that, but if I simply delete lines 267-269, it does resolve the issue.
To be thorough, I inspected the output for instances of lines containing
https://tools.ietf.org/html/rfc
at the end, aka what lines 267-269 would have operated on, and it's all links where the text is notRFC\d+
. Specifically:<a href="https://tools.ietf.org/html/rfc7231#appendix-D">media type range</a>
<a href="https://tools.ietf.org/html/rfc5234">ABNF</a>
requestBodies
section has one for each method, e.g.<a href="https://tools.ietf.org/html/rfc7231#section-4.3.1">GET</a>
Since that's the only instances affected by removing lines 267-269, this change seems very safe.