Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-Type for properties with type string and contentEncoding #3233

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Content-Type for properties with type string and contentEncoding #3233

merged 1 commit into from
Feb 1, 2024

Conversation

commonism
Copy link
Contributor

fixes #3230

@commonism commonism changed the base branch from main to v3.1.1-dev April 6, 2023 12:04
@handrews
Copy link
Member

handrews commented Apr 7, 2023

I should probably agree with past-me :-) Sadly, my current state (attempting to recover from COVID, which is going veerrrryyyyy slowly) has paused my effort to revamp the content* aspects of 3.1.1 along the same lines as PR #3187 did for format in 3.0.4.

I'm fine with merging this, but be aware that once my brain is back online I'm probably going to rewrite a lot of this section. Because even before I came down with COVID I struggled to follow it and I wrote most of it 😅 Plus, as we discussed #3187 we made some decisions that clarify all of this, as we realized that some of these combinations don't even make sense.

I have too much COVID-brain right now to figure out where this particular problem fits in all of that.

@MikeRalphson
Copy link
Member

Get well soon @handrews

@handrews handrews added this to the v3.1.1 milestone Jan 27, 2024
@handrews handrews added media and encoding Issues regarding media type support and how to encode data (outside of query/path params) clarification requests to clarify, but not change, part of the spec labels Jan 29, 2024
handrews
handrews approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the extended delay... "recovering from COVID" ended up being a more extended process than anticipated and I forgot about this PR. Although since 3.1.1 has yet to ship the practical impact is small.

But let's get this approved and merged now!

@handrews handrews mentioned this pull request Jan 29, 2024
Closed
@earth2marsh earth2marsh merged commit ea440c5 into OAI:v3.1.1-dev Feb 1, 2024
@commonism commonism deleted the contentEncoding311 branch February 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

@darrelmiller darrelmiller darrelmiller approved these changes

@asbjornu asbjornu asbjornu approved these changes

Assignees
No one assigned
Labels
clarification requests to clarify, but not change, part of the spec media and encoding Issues regarding media type support and how to encode data (outside of query/path params)
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

v3.1 - contentEncoding
6 participants
@commonism @handrews @MikeRalphson @asbjornu @darrelmiller @earth2marsh