fix: GitHub changed markdown rendering for headings/anchors #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
darrelmiller
approved these changes
Oct 19, 2023
This was referenced Jan 10, 2024
Closed
This was referenced Jan 15, 2024
handrews
added
clarification
|
@MikeRalphson could you rebase this and see if various javascript updates fixed the runtime checks? |
This was referenced Jan 30, 2024
|
Superseded by #3548 in order to get the PR checks to pass. Mike is still the credited author of the commit in the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3207 #3160 #3136 #3128 #3029 #3197 #3132
This PR mechanically corrects for the change made by GitHub to its markdown renderer which no longer honours the mixed markdown/html form:
### <a name="myAnchor"></a> My Anchor(the use of
nameoridmakes no difference), and only links to the implicit anchor#my-anchornow work.This PR affects the
mainbranch, so published versions of the OAS only. If merged, follow-up PRs will be raised for in-flight-devbranch versions.An example of the result of this PR can be previewed here.