-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect OpenIDConnect discovery url #3607
Conversation
@handrews : As discussed in the last call, I have made the changes to the existing PR now. Just to elaborate the changes again: The original spec had this text
The link to OpenID Connect discovery was mistakenly pointed to Oauth2 discovery specs - https://tools.ietf.org/html/draft-ietf-oauth-discovery-06. I later realized that the text (or reference) itself doesn't fit here, and it should rather be OpenID Connect Core (and not OpenID Connect Discovery) which would then refer to the link - https://openid.net/specs/openid-connect-core-1_0.html. I have now made both these changes to the existing PR. Could you kindly check? |
@lornajane were you the one that asked for changes here? All I remember that is that it quickly exceeded my knowledge in this area. @shilpa-padgaonkar's comment makes sense to me so my approval still stands. |
OpenID Connect Core URL fix (3.1.1 port of #3607)
Fixes #3152