-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] scripts/update-schema-id.sh #3814
[new] scripts/update-schema-id.sh #3814
Conversation
This script updates the schema IDs in the following YAML files: - schemas/v{major}.{minor}/schema.yaml - schemas/v{major}.{minor}/schema-base.yaml and generates the following JSON files from the updated YAML files: - schemas/v{major}.{minor}/schema.json - schemas/v{major}.{minor}/schema-base.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the script with -v 3.1
and it worked fine.
Running with -v 3.0
showed problems:
- schema.yaml was not updated
- schema-base.yaml was created empty
- schema-base.json was created with content
null
Thanks for providing the script. The script works fine for the v3.1 case with separate Would you mind adding this distinction to the scripts? Thanks in advance! |
If it is necessary to support versions older than 3.0, please let me know. |
@ralfhandl script so far looks good to me, but I'll let you run with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for both v3.1 and v3.0
I see you're using |
@karenetheridge Sorry, I did not know the |
I'm closing this pull request since it's no longer needed since the recent changes to the schema publishing process. |
This script updates the schema IDs in the following YAML files:
and generates the following JSON files from the updated YAML files: