Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize and streamline form media type guidance (3.1.1 modified port of 3923, 3929) #3937

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

handrews
Copy link
Member

@handrews handrews commented Jul 1, 2024

This just moves (and occasionally copies) blocks of text and/or
examples in preparation form more substantial streamlining.
No modifications were made to any block.
Make the Parameter, Encoding, and Header Object fixed fields
section organization the same in all three places, with the
same levels of indentation.

Add more headings under the Encoding Object for guidance on
each form media type, and sub-headings for each example in
each of those sections.

This will make the diff for the next commit much more legible.
This puts the useful part of the "An encoding attribute..."
text into the fixed fields table, and removes the duplication.

It also links the remaining stub or truncated sections to the
information's new location under the Encoding Object.
This re-organizes and streamlines the form-urlencoded guidance
that was consolidated from the Media Type Object.

It also adds an example of a base64-encoded URL query parameter.
I forgot to run the example through URL quoting, which is necessary.
@handrews handrews added clarification requests to clarify, but not change, part of the spec param serialization Issues related to parameter and/or header serialization media and encoding Issues regarding media type support and how to encode data (outside of query/path params) headers labels Jul 1, 2024
@handrews handrews added this to the v3.1.1 milestone Jul 1, 2024
@handrews handrews requested a review from a team July 1, 2024 21:58
This organizes and streamlines the guidance on multipart
that was incorporated from the Media Type Object.

Lots of duplication has been removed, and the examples
reworked to show distinct use cases.
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

versions/3.1.1.md Outdated Show resolved Hide resolved
versions/3.1.1.md Outdated Show resolved Hide resolved
@lornajane lornajane requested a review from a team July 4, 2024 16:44
@handrews
Copy link
Member Author

handrews commented Jul 9, 2024

@ralfhandl I've updated both places with links to clarification, and (in the second place) made sure it mentions the correct section.

@ralfhandl ralfhandl requested a review from a team July 10, 2024 13:09
@ralfhandl
Copy link
Contributor

@OAI/tsc Second review, please!

@whitlockjc whitlockjc merged commit 10308db into OAI:v3.1.1-dev Jul 11, 2024
1 check passed
@handrews handrews deleted the multipart-311 branch August 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification requests to clarify, but not change, part of the spec headers media and encoding Issues regarding media type support and how to encode data (outside of query/path params) param serialization Issues related to parameter and/or header serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants