Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build script: source-of-truth #4009

Merged
merged 14 commits into from
Aug 15, 2024
Merged

Build script: source-of-truth #4009

merged 14 commits into from
Aug 15, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 11, 2024

Builds on

Fixes #3576

Adds

  • added thisVersion and canonicalURL pointing to https://spec.openapis.org/oas/vM.m[.p].html
  • section "Status of this Document" now refers to HTML version as the source of truth
  • Measure test coverage with c8 because vitest's built-in coverage doesn't consider child processes
  • Add test cases to increase coverage

vitest's built-in coverage cannot measure into sub-processes, which is needed here.

c8 can 😄
@handrews handrews added the script Pull requests that update Bash or JavaScript code label Aug 11, 2024
@ralfhandl ralfhandl changed the title Build script: test coverage Build script: source-of-truth Aug 13, 2024
miqui
miqui previously approved these changes Aug 13, 2024
@ralfhandl ralfhandl requested a review from miqui August 14, 2024 11:35
@ralfhandl ralfhandl marked this pull request as ready for review August 14, 2024 12:52
@ralfhandl ralfhandl requested review from a team as code owners August 14, 2024 12:52
@rvedotrc
Copy link

Could you perhaps change the base of this PR, to the head of #4008?

Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl merged commit 9697c73 into OAI:main Aug 15, 2024
2 checks passed
@ralfhandl ralfhandl deleted the test/coverage branch August 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping script Pull requests that update Bash or JavaScript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is our authoritative spec URL and how do people find it?
5 participants