Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify security; state that [] is undefined behaviour #4012

Closed
wants to merge 1 commit into from

Conversation

rvedotrc
Copy link

Port of #4007 to v3.0.4-dev

versions/3.0.4.md Outdated Show resolved Hide resolved
versions/3.0.4.md Outdated Show resolved Hide resolved
@handrews
Copy link
Member

Oh I didn't see that there is a 3.1.1 that we're doing before this 3.0.4?

This is why we don't usually post the same fix to multiple branches at once- it's too confusing when there are a lot of notifications. We usually do the oldest branch, and then after that is accepted and merged we post any forward-port PRs.

@handrews handrews added security security: config The mechanics of severs and structure of security-related objects labels Aug 12, 2024
@rvedotrc
Copy link
Author

That's why this is a draft.

@rvedotrc
Copy link
Author

Oh I didn't see that there is a 3.1.1 that we're doing before this 3.0.4?

We can merge them in whatever order you like. I have three PRs open (two of which are draft), with essentially identical content. The discussion is mostly happening on the one for v3.1.1-dev, but that wasn't a deliberate decision; it is simply a result of me still getting to grips with the different branches we have, and how things are done.

@rvedotrc rvedotrc changed the title Clarify security; state that [] is undefined behaviour Clarify security; state that [] is undefined behaviour Aug 12, 2024
@handrews handrews added this to the v3.0.4 milestone Aug 22, 2024
@handrews
Copy link
Member

In today's TDC we agreed to re-try this based on @mikekistler 's "open world" view, so closing these three attempts.

@rvedotrc thank you for your contributions here- it is far from the first topic where we've had to go through multiple approaches, attempts, and PRs. Regardless of who writes the final PR, this has helped us immensely in figuring the problem out.

@handrews handrews closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security: config The mechanics of severs and structure of security-related objects security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants