-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown updates for 3.2.0 #4025
Conversation
ralfhandl
commented
Aug 15, 2024
•
edited
Loading
edited
- 3.2.0 port of
- Markdown updates for 3.1.1 #3991
- Run markdownlint after mdv on 3.1.1.md only because the older files won't pass
- Part of Add whitespace/formatting automation to the build process #3596
Fixed broken links kebab-case anchors markdownlint fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to what happens in which PR, so I'm just going to say the same thing on this one:
@ralfhandl can you re-do this with the tables not expanded since we agreed on that for the other branches? That will keep the change history so much less polluted on this branch.
Ideally I'd prefer not collapsing the spaces after periods, but I'm not going to my heels in on it (but it does create more noise and makes it harder to find sentence changes in a fixed-width editor).
The "table condenser" is currently only in #4040. @mikekistler has approved it half a dozen times already, and I'd happily merge it and port it to 3.1.1 and 3.2.0 with a second approval. |
This is the first part of several PRs to sync 3.2.0 with 3.1.1
We can merge them one by one, thus minimizing the differences, or just merge the last one with the cumulative changes and close the others. We'll need an additional diff to 3.1.1 to add the changes we did since the last of these PRs was created. |
|
||
##### Style Examples | ||
|
||
Assume a parameter named `color` has one of the following values: | ||
|
||
``` | ||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't exactly accurate but looks nicer than plain text so OK :-)
Merging as @mikekistler has approved before table condensing. |