Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.0: back out changes to Path Item Object and bring its $ref field back #4094

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Sep 13, 2024

Fixes #3734 by

  • adding $ref field back to Path Item Object
  • removing Reference Object as an alternative to Path Item Object in four places

Builds on and includes

@ralfhandl ralfhandl requested review from handrews and a team September 13, 2024 09:08
@ralfhandl ralfhandl added this to the v3.2.0 milestone Sep 13, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@handrews
Copy link
Member

@ralfhandl I'll look at this once the "built on" stack is resolved :-)

@ralfhandl
Copy link
Contributor Author

I'll look at this once the "built on" stack is resolved

In case you are curious, these are the changes: ralfhandl/OpenAPI-Specification@3.2.0-sync-with-3.1.1...3.2.0-back-out-changes-to-path-item-object

  • bring back $ref field in Path Item Object
  • remove Reference Object as an alternative to Path Item Object in four places

@handrews
Copy link
Member

@ralfhandl if we follow the proposal in #3677 (comment), we will not need this PR as we will just abandon v3.2.0-dev in favor of a reconstructed v3.2-dev, where the reconstruction just omits the commits that made this change that we want to back out.

@ralfhandl
Copy link
Contributor Author

@handrews Thanks for taking over!

@ralfhandl ralfhandl closed this Oct 22, 2024
@ralfhandl ralfhandl deleted the 3.2.0-back-out-changes-to-path-item-object branch October 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants