-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Fix Document vs Description terminology (3.1.1, port of #4100) #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Per post-TDC call with Darrel.
ralfhandl
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same three nits as in #4100
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
ralfhandl
approved these changes
Oct 14, 2024
mikekistler
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
editorial
Wording and stylistic issues
re-use: ref/id resolution
how $ref, operationId, or anything else is resolved
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is correct (and includes the last remaining "suggestion" about the Server Object
url
field wording), but please review carefully. I still need to re-review it myself, as resolving conflicts and adjusting for 3.1.1 was a bit complex in spots.Note that #4130 does not need to be ported as it is already handled by having the two distinct "Relative References in..." (URI vs URL) sections. Although those sections assume the split documented in #4130 that we said was ambiguous in 3.0.