make path → URL resolution clearer. #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't append a string to an object (at least not with a canonical result), so we should make clear that we want to append to the `url` field of the server object (possibly after filling in the templates there). The highlighting of "appended" makes it clearer that there is no relative URL resolution as mentioned in OAI#843 (comment).
|
I just rebased this branch to solve the conflicts. |
|
The changes look good to me. I wish we could avoid using the word "endpoint" but unfortunately there is no good word for thing that the |
|
@darrelmiller maybe "path family"? |
|
Let's not introduce new terminology now. Suggest opening a ticket for future clarifications. This can still make it in 3.0.0-FINAL (which will just be called 3.0.0). |
AndersDJohnson
pushed a commit
to AndersDJohnson/OpenAPI-Specification
that referenced
this pull request
Apr 8, 2019
make path → URL resolution clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't append a string to an object (at least not with a canonical result), so we should make clear that we want to append to the
urlfield of the server object (possibly after filling in the templates there).The highlighting of "appended" makes it clearer that there is no relative URL resolution as mentioned in #843 (comment).
The task list in #589 (comment) says the cleanup of the Paths object is already finished, so I felt free to add this edit now.