Skip to content

added version clarification #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2017
Merged

Conversation

fehguy
Copy link
Contributor

@fehguy fehguy commented Feb 21, 2017

Partially addresses concern in #589

@webron
Copy link
Member

webron commented Feb 21, 2017

LGTM.

@darrelmiller
Copy link
Member

:shipit:

1 similar comment
@whitlockjc
Copy link
Member

:shipit:

@@ -221,7 +222,7 @@ Field Name | Type | Description
<a name="infoTermsOfService"></a>termsOfService | `string` | A URL to the Terms of Service for the API.
<a name="infoContact"></a>contact | [Contact Object](#contactObject) | The contact information for the exposed API.
<a name="infoLicense"></a>license | [License Object](#licenseObject) | The license information for the exposed API.
<a name="infoVersion"></a>version | `string` | **Required** Provides the version of the application API (not to be confused with the specification version).
<a name="infoVersion"></a>version | `string` | **Required** Provides the version of the application API (not to be confused with the specification version). While not required, is it suggested that the `info.version` value correspond to the version of the API definition. In practice, the version of the API _implementation_ may evolve at an entirely different rate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is marked Requried, then the second sentence starts "While not required". Some may be confused and think this starts a contradiction. I suggest not adding this sentence at all, as it only raises additional questions (is "application API === "API definition"?) Instead, I suggest rephrasing, introducing fewer new/undefined/ambiguous terms:

Required Provides the version of the API (not to be confused with the OpenAPI specification version or the implementation version which may evolve at different rates).

Copy link
Contributor

@RobDolinMS RobDolinMS Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidBiesack Would you please consider opening this as a separate issue or PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobDolinMS - sure, see #905

versions/3.0.md Outdated
1.1 | 2012-08-22 | Release of Swagger 1.1
1.0 | 2011-08-10 | First release of the Swagger Specification
--- | --- | ---
3.0.0 | 2017-02-28 | Implementor's draft of the 3.0 specification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we follow a model of calling this v3.0.0-rc0 (release candidate zero) and then when we have polished, we're at v3.0.0-rc1 (or rc2 or rc3) and then we have a v3.0.0-final (and can delete the release candidates)

@fehguy
Copy link
Contributor Author

fehguy commented Feb 22, 2017

@OAI/tdc I've updated the version to be 3.0.0.-rc0 per call.

@fehguy fehguy merged commit df786d7 into OpenAPI.next Feb 22, 2017
@fehguy fehguy deleted the issue-589-version-clarification branch February 22, 2017 17:13
AndersDJohnson pushed a commit to AndersDJohnson/OpenAPI-Specification that referenced this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants