Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema stub and schema tests #86

Merged
merged 8 commits into from
Nov 5, 2024
Merged

Add schema stub and schema tests #86

merged 8 commits into from
Nov 5, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Oct 21, 2024 •
edited
Loading

Copies useful stuff over from OpenAPI repo and adjusts it for Overlay:

  • stub for schemas/v1.0/schema.yaml
  • tests for the schema with pass and fail test cases
  • all spec examples are pass test cases
  • workflow to run schema tests
  • validate script for ad-hoc schema validation

@ralfhandl ralfhandl requested review from lornajane, mikekistler and a team October 21, 2024 14:45
@jeremyfiel jeremyfiel mentioned this pull request Oct 21, 2024
Closed
@ralfhandl ralfhandl requested review from jeremyfiel and kevinswiber and removed request for jeremyfiel October 21, 2024 16:02
@ralfhandl ralfhandl added this to the Release 1.0 milestone Oct 21, 2024
@ralfhandl ralfhandl requested a review from jeremyfiel October 23, 2024 07:34
jeremyfiel
jeremyfiel approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@jeremyfiel jeremyfiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the changes to your fork for the new tests I've committed? Other than the naming, lgtm!

scripts/validate.mjs Outdated Show resolved Hide resolved
tests/v1.0/schema.test.mjs Outdated Show resolved Hide resolved
@ralfhandl ralfhandl requested a review from jeremyfiel October 23, 2024 14:15
jeremyfiel
jeremyfiel approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@jeremyfiel jeremyfiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

mikekistler
mikekistler approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl merged commit 004e0bc into OAI:main Nov 5, 2024
2 checks passed
@ralfhandl ralfhandl deleted the schema-test branch November 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@jeremyfiel jeremyfiel jeremyfiel approved these changes

@lornajane lornajane Awaiting requested review from lornajane

@kevinswiber kevinswiber Awaiting requested review from kevinswiber

Assignees
No one assigned
Labels
Schema
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ralfhandl @jeremyfiel @mikekistler