Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema tests and official JSON Schema #94

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jeremyfiel
Copy link
Contributor

includes pass and fail scenarios for Overlay schema tests.

Also includes the full schema per #72

@ralfhandl ralfhandl added this to the Release 1.0 milestone Nov 5, 2024
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
mikekistler
mikekistler previously approved these changes Nov 5, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
tests/v1.0/fail/actions-no-update-with-remove.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
schemas/v1.0/schema.yaml Outdated Show resolved Hide resolved
@jeremyfiel jeremyfiel force-pushed the schema-test branch 2 times, most recently from d1907bc to 84db575 Compare November 8, 2024 16:07
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, only minor nits.

Thank you!

tests/v1.0/fail/extends-invalid-type.yaml Outdated Show resolved Hide resolved
tests/v1.0/fail/info-missing-title.yaml Outdated Show resolved Hide resolved
schemas/v1.0/readme.md Outdated Show resolved Hide resolved
@ralfhandl
Copy link
Contributor

@jeremyfiel Could you please add a description to one of the Action Objects?

That's the only part of the schema that is not yet tested.

@jeremyfiel jeremyfiel force-pushed the schema-test branch 2 times, most recently from dc198e7 to 5517ebc Compare November 12, 2024 14:58
@jeremyfiel
Copy link
Contributor Author

should be all covered now

@jeremyfiel jeremyfiel requested a review from ralfhandl November 12, 2024 14:58
@ralfhandl
Copy link
Contributor

should be all covered now

Sorry, should have been more precise: please add to a "pass" test case, the "fail" ones don't count into the schema coverage.

* fixup `target` json path
* remove constraint for no update with remove
* update schema tests for update and remove definition
@jeremyfiel
Copy link
Contributor Author

removed constraints for update/remove, updated tests

@ralfhandl
Copy link
Contributor

@jeremyfiel How can I view the diff between this state and the last state I reviewed?

@jeremyfiel
Copy link
Contributor Author

There is a compare hyperlink just above our comment box. It's not available on mobile so I don't have it to share. It's available on desktop though

@ralfhandl ralfhandl requested review from lornajane and a team November 20, 2024 11:01
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl merged commit 1d28463 into OAI:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants