Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema test: improved error diagnostics #95

Merged
merged 1 commit into from
Dec 3, 2024
Merged

schema test: improved error diagnostics #95

merged 1 commit into from
Dec 3, 2024

Conversation

ralfhandl
Copy link
Contributor

  • error details if schema doesn't validate
  • error details if "pass" test case fails

@ralfhandl
schema test: error if schema doesn't validate
e9e0a31 
Error diagnostics if pass test case fails
@ralfhandl ralfhandl requested a review from a team November 8, 2024 13:31
mikekistler
mikekistler approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@ralfhandl ralfhandl merged commit fbeb941 into OAI:main Dec 3, 2024
2 checks passed
@ralfhandl ralfhandl deleted the schema-test-invalid-schema branch December 3, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@lornajane lornajane Awaiting requested review from lornajane

@handrews handrews Awaiting requested review from handrews

Assignees
No one assigned
Labels
Housekeeping Schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralfhandl @mikekistler