Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Release Process? #13

Closed
vorburger opened this issue Apr 5, 2018 · 6 comments
Closed

JS Release Process? #13

vorburger opened this issue Apr 5, 2018 · 6 comments

Comments

@vorburger
Copy link
Member

as discussed in https://github.com/vorburger/minecraft-storeys-maker/pull/4, with the change from the original minecraft.js to a src/index.ts which we build into JS, we'll have to "release" both that JS as well as the matching version of the web-1.0.0-SNAPSHOT-all.jar together somewhere... for me, this is not a high prio while we're still in dev, but let's have this issue to create the neccessary scripting and documentation, when we get to it. I'm personally more interested in a CI/CD to get it all together cloud hosted... ;-)

@edewit
Copy link
Member

edewit commented Apr 5, 2018

we could use github releases to host our binaries and use a gradle plugin or something similar to let travis create these releases.

@vorburger
Copy link
Member Author

#19 may make this a non-issue - or perhaps for #19 I'll find that we should bundle the JS into the JAR...

@vorburger vorburger changed the title Release Process? JS Release Process? Apr 18, 2018
vorburger added a commit that referenced this issue Apr 18, 2018
this addresses the JS release/deployment process issue #13

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
@vorburger
Copy link
Member Author

@edewit OK for you to close this via #29 ? That works great - I don't see the need to ever do anything else.

vorburger added a commit that referenced this issue Apr 18, 2018
this addresses the JS release/deployment process issue #13

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
@edewit
Copy link
Member

edewit commented Apr 19, 2018

right, we should then merge the scratchJSExtensionURL and the eventBusURL into one parameter

@vorburger
Copy link
Member Author

right, we should then merge the scratchJSExtensionURL and the eventBusURL into one parameter

I was thinking that hypothetically purely theoretically in a future far far away in a huge cluster of many Minecraft sub server nodes perhaps the static JS app content would also be exposed on an external CDN after all, while the EventBus would be on a different URL, so it couldn't hurt to keep them separate - even though, in the short term, they will typically both have the same base hostname (but not port and URL).

@edewit
Copy link
Member

edewit commented Apr 19, 2018

right makes sense, let's keep them separate for now

vorburger added a commit that referenced this issue Apr 19, 2018
this addresses the JS release/deployment process issue #13

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants